Bug 249266 - Figure out how to tell if a Web Extension has been updated in WebKit
Summary: Figure out how to tell if a Web Extension has been updated in WebKit
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Extensions (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Timothy Hatcher
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-12-13 15:29 PST by Kiara Rose
Modified: 2024-04-03 13:06 PDT (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kiara Rose 2022-12-13 15:29:15 PST 
Figure out how to tell if a Web Extension has been updated in WebKit and remove the background page listeners if the extension has been updated.
Comment 1 Kiara Rose 2022-12-13 15:31:28 PST 
When developers are making local changes to their extension for testing, they're likely not changing the extension version number.
Comment 2 Kiara Rose 2022-12-13 16:34:09 PST 
One option would be the take a hash of all the files in the bundle, and if any change assume it changed
Comment 3 Radar WebKit Bug Importer 2022-12-20 15:30:17 PST 
<rdar://problem/103573769>
Comment 4 Timothy Hatcher 2023-10-04 10:17:10 PDT 
One option is to check and remember the previous code signing hash. That should change everything there is a change in the bundle.
Comment 5 Kiara Rose 2023-12-06 15:42:11 PST 
Tim mentioned an idea of hashing all the files and seeing if the hash changes
Comment 6 Timothy Hatcher 2024-04-02 23:55:10 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/26778
Comment 7 EWS 2024-04-03 13:06:31 PDT 
Committed 277022@main (adf9728dc4e1): <https://commits.webkit.org/277022@main>

Reviewed commits have been landed. Closing PR #26778 and removing active labels.