Bug 249210 - [margin-trim] Implement margin trim for grid containers
Summary: [margin-trim] Implement margin trim for grid containers
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Sammy Gill
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-12-12 22:31 PST by Sammy Gill
Modified: 2023-01-06 17:56 PST (History)
4 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sammy Gill 2022-12-12 22:31:59 PST 
For grid containers specifically, margin-trim discards the corresponding margin of each grid item in the grid track adjacent to the relevant box edge.

This process ignores any collapsed grid tracks. It does not otherwise ignore any empty grid tracks.

https://w3c.github.io/csswg-drafts/css-box-4/#margin-trim-grid
Comment 1 Radar WebKit Bug Importer 2022-12-12 22:32:23 PST 
<rdar://problem/103285873>
Comment 2 Sammy Gill 2023-01-04 16:42:37 PST 
Pull request: https://github.com/WebKit/WebKit/pull/8220
Comment 3 EWS 2023-01-06 17:56:21 PST 
Committed 258587@main (e8f3117677da): <https://commits.webkit.org/258587@main>

Reviewed commits have been landed. Closing PR #8220 and removing active labels.