Bug 249175 - Removal of Bugzilla_restrictlogin from bugs.webkit.org login template breaks webkit-patch tool
Summary: Removal of Bugzilla_restrictlogin from bugs.webkit.org login template breaks ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: lingho@apple.com
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-12-12 14:05 PST by lingho@apple.com
Modified: 2022-12-12 15:40 PST (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description lingho@apple.com 2022-12-12 14:05:34 PST 
The Bugzilla_restriclogin form item was removed from WebKit Bugzilla's login template. The webkit-upload tool setting the item to False (in Tools/./Scripts/webkitpy/common/net/bugzilla/bugzilla.py) is failing. Similar code also found in Tools/CISupport/ews-app/ews/common/bugzilla.py.

Bugzilla ignore the setting if it does not exist, equivalent to setting it to False.
Comment 1 Radar WebKit Bug Importer 2022-12-12 14:06:12 PST 
<rdar://problem/103269204>
Comment 2 lingho@apple.com 2022-12-12 14:12:57 PST 
Pull request: https://github.com/WebKit/WebKit/pull/7505
Comment 3 EWS 2022-12-12 15:40:45 PST 
Committed 257762@main (6475102d6dba): <https://commits.webkit.org/257762@main>

Reviewed commits have been landed. Closing PR #7505 and removing active labels.