RESOLVED FIXED249119
Web Inspector: Use-after-scope in lambda in WebCore::isValidRuleHeaderText() 
https://bugs.webkit.org/show_bug.cgi?id=249119
Summary Web Inspector: Use-after-scope in lambda in WebCore::isValidRuleHeaderText()
David Kilzer (:ddkilzer)
Reported 2022-12-11 20:20:59 PST
Web Inspector: Use-after-scope in lambda in WebCore::isValidRuleHeaderText(). Currently, `CSSParserImpl` holds a reference to the `CSSParserContext` argument, so the context must outlive the parser. However, in this code the context is a temporary stack variable which is destroyed after this statement, though the parser holds a reference to it. ``` CSSParserImpl parser(parserContextForDocument(document), atRuleIdentifier + ' ' + headerText + " {}"); ``` <rdar://102887283>
Attachments
Add attachment proposed patch, testcase, etc.
David Kilzer (:ddkilzer)
Comment 1 2022-12-11 20:21:38 PST
This regressed here: Web Inspector: Support editing @rules in the Styles sidebar https://bugs.webkit.org/show_bug.cgi?id=246768 <https://commits.webkit.org/256043@main>
David Kilzer (:ddkilzer)
Comment 2 2022-12-11 20:30:25 PST
Pull request: https://github.com/WebKit/WebKit/pull/7466
EWS
Comment 3 2022-12-12 03:20:08 PST
Committed 257722@main (599c0cb20b81): <https://commits.webkit.org/257722@main> Reviewed commits have been landed. Closing PR #7466 and removing active labels.
Note You need to log in before you can comment on or make changes to this bug.