Bug 249104 - [css-grid] GridMasonryLayout::addItemsToFirstTrack remove unnecessary nullptr check
Summary: [css-grid] GridMasonryLayout::addItemsToFirstTrack remove unnecessary nullptr...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-12-11 11:53 PST by Sammy Gill
Modified: 2022-12-11 21:11 PST (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sammy Gill 2022-12-11 11:53:42 PST 
GridMasonryLayout::addItemsToFirstTrack iterators over a HashMap that uses raw pointers as keys. The HashMap implementation would not allow this to happen so we can probably remove the check
Comment 1 Radar WebKit Bug Importer 2022-12-11 11:54:01 PST 
<rdar://problem/103230303>
Comment 2 Sammy Gill 2022-12-11 12:03:45 PST 
Pull request: https://github.com/WebKit/WebKit/pull/7455
Comment 3 EWS 2022-12-11 21:11:31 PST 
Committed 257714@main (3f50a04024eb): <https://commits.webkit.org/257714@main>

Reviewed commits have been landed. Closing PR #7455 and removing active labels.