Bug 249083 - Remove unused WTF::StreamBuffer class
Summary: Remove unused WTF::StreamBuffer class
Status: RESOLVED INVALID
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: Safari Technology Preview
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-12-10 15:48 PST by Ahmad Saleem
Modified: 2022-12-11 11:06 PST (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ahmad Saleem 2022-12-10 15:48:27 PST 
Hi Team,

I am not sure on the uses internally but I just wanted to create this bug so if this can be removed similar to how Blink removed in 2015 then we should get rid of this:

Blink Commit - https://chromium.googlesource.com/chromium/blink/+/15865e3dd893e80939987d37a04c45f7bb5bcbe7

From the history of commit to file, it seems that they are infrequent: https://github.com/WebKit/WebKit/commits/68b73575a9aa740856dde6a891945e21a4a8b207/Source/WTF/wtf/StreamBuffer.h

Thanks!
Comment 1 Alexey Proskuryakov 2022-12-11 11:06:51 PST 
StreamBuffer is used in WebKit, as evidenced by "grep -r StreamBuffer Source".

I don't think that tracking Blink refactoring patches is worth the time - the engines have diverged a lot, and we won't necessarily want to make the same choices anyway.