Bug 249081 - Potential Crash fix in Media while video is running and pressing and navigate away from page
Summary: Potential Crash fix in Media while video is running and pressing and navigate...
Status: RESOLVED INVALID
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: Safari Technology Preview
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-12-10 15:07 PST by Ahmad Saleem
Modified: 2022-12-11 11:23 PST (History)
4 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ahmad Saleem 2022-12-10 15:07:32 PST 
HI Team,

While going through Blink's commit, I came across another potential crash fix but it does not have any test case and if it is OK to land as it is. I am happy to do so:

Blink Commit - https://chromium.googlesource.com/chromium/src.git/+/8a30a6faefc51b7e11bfc9f5aa22254323d0aee8

Webkit GitHub Source - https://github.com/WebKit/WebKit/blob/40f4e5e1facea60ca8d6e709d3c5d9d97a33e105/Source/WebCore/html/HTMLMediaElement.cpp#L2630

Just wanted to raise this to confirm if it is good to fix and it might fix some crashes or make it more fail-safe.

Thanks!
Comment 1 Alexey Proskuryakov 2022-12-11 11:23:12 PST 
Others can reopen if the want to take a look, but it doesn't seem worth investigating if any given Blink patch is relevant to WebKit unless there is a strong evidence that we have the same bug (such as a failing test case).