Bug 249075 - Check for promise before resolving in FullscreenManager::exitFullscreen()
Summary: Check for promise before resolving in FullscreenManager::exitFullscreen()
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tim Nguyen (:ntim)
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-12-10 10:45 PST by Tim Nguyen (:ntim)
Modified: 2022-12-10 16:09 PST (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Nguyen (:ntim) 2022-12-10 10:45:20 PST 
The promise can be nullptr if called from the legacy fullscreen API (see DocumentFullscreen::webkitExitFullScreen), so we should check it's existence before trying to resolve.
Comment 1 Radar WebKit Bug Importer 2022-12-10 10:45:45 PST 
<rdar://problem/103215492>
Comment 2 Tim Nguyen (:ntim) 2022-12-10 10:47:25 PST 
Pull request: https://github.com/WebKit/WebKit/pull/7443
Comment 3 EWS 2022-12-10 16:09:50 PST 
Committed 257689@main (91d9d701a8cd): <https://commits.webkit.org/257689@main>

Reviewed commits have been landed. Closing PR #7443 and removing active labels.