Bug 249051 - [ews] re-run-layout-tests ignores the failures when first layout test run failed with infra issue
Summary: [ews] re-run-layout-tests ignores the failures when first layout test run fai...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Aakash Jain
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-12-09 15:54 PST by Aakash Jain
Modified: 2023-01-09 09:00 PST (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Aakash Jain 2022-12-09 15:54:54 PST 
[ews] re-run-layout-tests ignores the failures when first layout test run failed with infra issue. 

eg.: https://ews-build.webkit.org/#/builders/10/builds/168571, https://ews-build.webkit.org/#/builders/10/builds/168925, https://ews-build.webkit.org/#/builders/10/builds/169015
In these runs first layout-tests failed and didn't even run layout-tests, re-run-layout-tests noticed some failures and compared with first run and thought them to be flaky and so ignored them.

 
re-run-layout-tests shouldn't ignore the failures (as flaky) when first layout test run failed with infra issue.
Comment 1 Radar WebKit Bug Importer 2022-12-16 15:55:16 PST 
<rdar://problem/103464148>
Comment 2 Aakash Jain 2023-01-09 09:00:55 PST 
This was fixed by https://github.com/WebKit/WebKit/pull/7417