Bug 249049 - [ews] Commit-Queue pre-maturely finished the build after re-run-layout-tests
Summary: [ews] Commit-Queue pre-maturely finished the build after re-run-layout-tests
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Aakash Jain
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-12-09 15:44 PST by Aakash Jain
Modified: 2022-12-12 20:13 PST (History)
3 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Aakash Jain 2022-12-09 15:44:25 PST 
[ews] Commit-Queue pre-maturely finished the build after re-run-layout-tests in https://ews-build.webkit.org/#/builders/28/builds/23819 and https://ews-build.webkit.org/#/builders/28/builds/23845.

We recently added logic in https://bugs.webkit.org/show_bug.cgi?id=248553 to Skip run-layout-tests-without-change step when first and second layout test run have only flaky failures. However, that logic is pre-maturely exiting the build for Commit-Queue as well.
Comment 1 Radar WebKit Bug Importer 2022-12-09 15:47:10 PST 
<rdar://problem/103197446>
Comment 2 Aakash Jain 2022-12-09 15:48:37 PST 
Pull request: https://github.com/WebKit/WebKit/pull/7417
Comment 3 EWS 2022-12-12 20:13:33 PST 
Committed 257773@main (0c9ae1207142): <https://commits.webkit.org/257773@main>

Reviewed commits have been landed. Closing PR #7417 and removing active labels.