Bug 249045 - [ews] Improve handling of non-existing status-bubbles
Summary: [ews] Improve handling of non-existing status-bubbles
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Aakash Jain
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-12-09 14:34 PST by Aakash Jain
Modified: 2022-12-09 15:12 PST (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Aakash Jain 2022-12-09 14:34:13 PST 
[ews] Improve handling of non-existing status-bubbles on Github.
Comment 1 Radar WebKit Bug Importer 2022-12-09 14:34:50 PST 
<rdar://problem/103194910>
Comment 2 Aakash Jain 2022-12-09 14:36:31 PST 
Exception from logs:

  File "/var/ews/OpenSource/Tools/CISupport/ews-app/ews/common/github.py", line 230, in generate_comment_text_for_change
    comment_for_row += self.github_status_for_queue(change, queue)
  File "/var/ews/OpenSource/Tools/CISupport/ews-app/ews/common/github.py", line 272, in github_status_for_queue
    return u'| [{icon} {name} ]({url} "{hover_over_text}") '.format(icon=icon, name=name, url=url, hover_over_text=hover_over_text)
UnboundLocalError: local variable 'url' referenced before assignment
Comment 3 Aakash Jain 2022-12-09 14:37:06 PST 
Pull request: https://github.com/WebKit/WebKit/pull/7410
Comment 4 EWS 2022-12-09 15:11:50 PST 
Committed 257648@main (7d063a43b838): <https://commits.webkit.org/257648@main>

Reviewed commits have been landed. Closing PR #7410 and removing active labels.