Bug 249034 - [WPE] Checkout a specific version of Cog instead of master
Summary: [WPE] Checkout a specific version of Cog instead of master
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WPE WebKit (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Michael Catanzaro
URL:
Keywords:
Depends on:
Blocks: 249031 220117
  Show dependency tree / graph
 
Reported: 2022-12-09 11:16 PST by Carlos Alberto Lopez Perez
Modified: 2023-02-12 09:06 PST (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos Alberto Lopez Perez 2022-12-09 11:16:59 PST 
When building Cog after building WebKit (with the script build-webkit) we are currently picking the last master of Cog, but we should instead pick a specific commit and update this manually.

Cog will be used to run the performance tests (see bug 249031 ) so is important that we know exactly which version was running when you bisect a commit of WebKit looking for performance regressions.
Comment 1 Michael Catanzaro 2022-12-12 14:20:31 PST 
Pull request: https://github.com/WebKit/WebKit/pull/7508
Comment 2 Michael Catanzaro 2023-01-16 10:47:12 PST 
(In reply to Michael Catanzaro from comment #1)
> Pull request: https://github.com/WebKit/WebKit/pull/7508

Wound up closing this pull request. The change is now integrated into this pull request instead:

https://github.com/WebKit/WebKit/pull/5944