Bug 248952 - [EWS] Layout test results should still be and extracted even if failure is ignored based on results db data
Summary: [EWS] Layout test results should still be and extracted even if failure is ig...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Aakash Jain
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-12-08 09:00 PST by Ryan Haddad
Modified: 2022-12-12 15:53 PST (History)
4 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ryan Haddad 2022-12-08 09:00:05 PST 
With the new results database checking behavior, if EWS deems a failure to be ignorable, we skip the steps to archive and upload the layout test results.

We should still perform these steps so that we are able to view and reason about the results.
Comment 1 Radar WebKit Bug Importer 2022-12-08 09:00:33 PST 
<rdar://problem/103120038>
Comment 2 Aakash Jain 2022-12-08 11:31:14 PST 
Pull request: https://github.com/WebKit/WebKit/pull/7335
Comment 3 EWS 2022-12-08 11:46:50 PST 
Committed 257578@main (9506ddb0c52c): <https://commits.webkit.org/257578@main>

Reviewed commits have been landed. Closing PR #7335 and removing active labels.
Comment 4 Aakash Jain 2022-12-12 15:53:17 PST 
This change is working properly, e.g.: https://ews-build.webkit.org/#/builders/70/builds/23652