Bug 248928 - REGRESSION(256795@main) [WPE][WebDriver] Replace deleted browser environment function in tooling
Summary: REGRESSION(256795@main) [WPE][WebDriver] Replace deleted browser environment ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Lauro Moura
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-12-07 21:04 PST by Lauro Moura
Modified: 2022-12-08 06:06 PST (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Lauro Moura 2022-12-07 21:04:33 PST 
Traceback (most recent call last):
  File "/app/webkit/Tools/Scripts/run-webdriver-tests", line 85, in <module>
    runner.run(args)
  File "/app/webkit/Tools/Scripts/webkitpy/webdriver_tests/webdriver_test_runner.py", line 70, in run
    runner_tests = [runner.collect_tests(tests) for runner in self._runners]
  File "/app/webkit/Tools/Scripts/webkitpy/webdriver_tests/webdriver_test_runner.py", line 70, in <listcomp>
    runner_tests = [runner.collect_tests(tests) for runner in self._runners]
  File "/app/webkit/Tools/Scripts/webkitpy/webdriver_tests/webdriver_test_runner_selenium.py", line 49, in collect_tests
    executor = WebDriverSeleniumExecutor(self._driver, self._env)
  File "/app/webkit/Tools/Scripts/webkitpy/webdriver_tests/webdriver_selenium_executor.py", line 41, in __init__
    self._env.update(driver.browser_env())
  File "/app/webkit/Tools/Scripts/webkitpy/webdriver_tests/webdriver_driver_wpe.py", line 54, in browser_env
    return self._port.browser_env()
AttributeError: 'WPEPort' object has no attribute 'browser_env'. Did you mean: 'browser_name'?

Patch incoming.
Comment 1 Lauro Moura 2022-12-07 21:09:52 PST 
Pull request: https://github.com/WebKit/WebKit/pull/7303
Comment 2 EWS 2022-12-08 06:05:20 PST 
Committed 257561@main (c16db3c1853c): <https://commits.webkit.org/257561@main>

Reviewed commits have been landed. Closing PR #7303 and removing active labels.
Comment 3 Radar WebKit Bug Importer 2022-12-08 06:06:19 PST 
<rdar://problem/103115761>