Bug 248801 - [ews-build.webkit.org] Commit URL assigned to wrong step
Summary: [ews-build.webkit.org] Commit URL assigned to wrong step
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jonathan Bedard
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-12-05 16:50 PST by Jonathan Bedard
Modified: 2022-12-06 16:51 PST (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Bedard 2022-12-05 16:50:08 PST 
When we're checking out a specific revision, the commit URL should be assigned to the step which checks out the specific revision, rather than the step updating the checkout. This was generally true for patches, but https://commits.webkit.org/257373@main broke this for PRs. To prevent future confusions of this sort, we should link ShowIdentifier and CheckOutSpecificRevision via code instead of via a comment.
Comment 1 Radar WebKit Bug Importer 2022-12-05 16:50:37 PST 
<rdar://problem/103003905>
Comment 2 Jonathan Bedard 2022-12-05 16:52:53 PST 
Pull request: https://github.com/WebKit/WebKit/pull/7180
Comment 3 EWS 2022-12-06 16:51:39 PST 
Committed 257450@main (124a3086a938): <https://commits.webkit.org/257450@main>

Reviewed commits have been landed. Closing PR #7180 and removing active labels.