Bug 248769 - [LegacySVG] Return vertical writing mode aware intrinsic information for SVG
Summary: [LegacySVG] Return vertical writing mode aware intrinsic information for SVG
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: SVG (show other bugs)
Version: Safari Technology Preview
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-12-05 11:30 PST by Ahmad Saleem
Modified: 2023-05-18 08:37 PDT (History)
3 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ahmad Saleem 2022-12-05 11:30:54 PST 
Hi Team,

While going through Blink's commit, I came across following commit:

Commit - https://chromium.googlesource.com/chromium/blink/+/60af46f13e39be1daacbcdab27c4e7212ae27886

Webkit GitHub Source - https://github.com/WebKit/WebKit/blob/ecaf5946d7a021d6e1d8bda4bb6e2c990a73d26a/Source/WebCore/rendering/svg/RenderSVGRoot.cpp#LL108 & https://github.com/WebKit/WebKit/blob/ecaf5946d7a021d6e1d8bda4bb6e2c990a73d26a/Source/WebCore/rendering/svg/RenderSVGRoot.cpp#L118

Test Failing (Firefox Nightly 109 & Chrome Canary 110 passes) - https://jsfiddle.net/28hwu6cy/show

Just wanted to raise bug before trying to merge this fix.

Thanks!
Comment 1 Radar WebKit Bug Importer 2022-12-12 11:31:17 PST 
<rdar://problem/103262534>
Comment 2 Ahmad Saleem 2023-05-18 07:48:44 PDT 
    if (!isHorizontalWritingMode())
        intrinsicSize = intrinsicSize.transposedSize();    

 if (!isHorizontalWritingMode())
                intrinsicRatioValue = 1 / intrinsicRatio

^ This make us pass another one of the test similar to Blink patch. I tried that in the past but didn't work. I might have done something silly.
Comment 3 Ahmad Saleem 2023-05-18 08:35:50 PDT 
https://github.com/WebKit/WebKit/pull/14014 <- at least fixing one test case.