Bug 248721 - Avoid trailing whitespace when generating import-expectations.json
Summary: Avoid trailing whitespace when generating import-expectations.json
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tim Nguyen (:ntim)
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-12-03 15:06 PST by Tim Nguyen (:ntim)
Modified: 2022-12-03 15:18 PST (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Nguyen (:ntim) 2022-12-03 15:06:17 PST 
Generating import-expectations.json can cause trailing whitespaces, in older versions of Python, this causes noise in WPT import diffs.

This is because older versions of python have `separators=(', ', ': ')` as default separators instead of `separators=(',', ': ')`.
Comment 1 Radar WebKit Bug Importer 2022-12-03 15:08:38 PST 
<rdar://problem/102940524>
Comment 2 Tim Nguyen (:ntim) 2022-12-03 15:12:41 PST 
Pull request: https://github.com/WebKit/WebKit/pull/7121
Comment 3 EWS 2022-12-03 15:18:27 PST 
Committed 257335@main (06d28085c8e7): <https://commits.webkit.org/257335@main>

Reviewed commits have been landed. Closing PR #7121 and removing active labels.