Bug 248714 - Align modern & old codepaths for fullscreen API
Summary: Align modern & old codepaths for fullscreen API
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tim Nguyen (:ntim)
URL:
Keywords: InRadar
Depends on:
Blocks: fullscreen-cleanup
  Show dependency tree / graph
 
Reported: 2022-12-03 10:41 PST by Tim Nguyen (:ntim)
Modified: 2024-07-20 21:42 PDT (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Nguyen (:ntim) 2022-12-03 10:41:08 PST 
The original implementation of the unprefixed API tried to make as little change as possible to the prefixed API.

The only difference between the two methods is the `isFullyActive()` check. Since we successfully unified that check for `Element::requestFullscreen` in https://commits.webkit.org/255551@main, we should also do it for `Document::fullscreenEnabled`.
Comment 1 Radar WebKit Bug Importer 2022-12-03 10:41:17 PST 
<rdar://problem/102937855>
Comment 2 Tim Nguyen (:ntim) 2022-12-03 11:14:17 PST 
Pull request: https://github.com/WebKit/WebKit/pull/7117