Bug 248666 - Implement representation for CounterStyle translated from StyleRuleCounterStyle
Summary: Implement representation for CounterStyle translated from StyleRuleCounterStyle
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: Safari 15
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Vitor Roriz
URL:
Keywords: InRadar
Depends on:
Blocks: 167645
  Show dependency tree / graph
 
Reported: 2022-12-02 10:26 PST by Vitor Roriz
Modified: 2023-01-04 09:15 PST (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Vitor Roriz 2022-12-02 10:26:13 PST 
Currently, CounterStyle parsing parses everything into CSS values. We need a CounterStyle representation that can be
used for later implementing CounterStyle rendering.

We can instantiate CounterStyle when building at-rules in the StyleResolver. Later on, during Style building, we can resolve the list-style-type to 
a CounterStyle and store it in the element's RenderStyle.

This will not cover the actual rendering of list marker (RenderListMarker).
Comment 1 Radar WebKit Bug Importer 2022-12-02 10:26:27 PST 
<rdar://problem/102910060>
Comment 2 Vitor Roriz 2022-12-03 08:08:53 PST 
Pull request: https://github.com/WebKit/WebKit/pull/7114
Comment 3 EWS 2023-01-04 09:15:53 PST 
Committed 258434@main (ac2f8a4229ce): <https://commits.webkit.org/258434@main>

Reviewed commits have been landed. Closing PR #7114 and removing active labels.