WebKit Bugzilla
New
Browse
Search+
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
NEW
248628
Remove ApplePasteAsQuotation class handling
https://bugs.webkit.org/show_bug.cgi?id=248628
Summary
Remove ApplePasteAsQuotation class handling
Ahmad Saleem
Reported
2022-12-01 13:08:12 PST
Hi Team, While going through Blink's commit, I came across another about removing old code: Blink Commit -
https://chromium.googlesource.com/chromium/src.git/+/5c10c52ba10b124c002ab47a7165d983d9869e51
Webkit GitHub Source (Example) -
https://github.com/WebKit/WebKit/blob/bb23e4eae6409a6dc22a4499c3ac9bdf7a4e56df/Source/WebCore/editing/Editor.cpp#L1592
&
https://github.com/WebKit/WebKit/blob/bb23e4eae6409a6dc22a4499c3ac9bdf7a4e56df/Source/WebCore/editing/ReplaceSelectionCommand.cpp#L1077
&
https://github.com/WebKit/WebKit/blob/bb23e4eae6409a6dc22a4499c3ac9bdf7a4e56df/Source/WebCore/editing/ReplaceSelectionCommand.cpp#L513
Just wanted to raise bug to remove it after input from others that it is not used internally and we can remove it safely. Thanks!
Attachments
Add attachment
proposed patch, testcase, etc.
Ahmad Saleem
Comment 1
2022-12-08 07:54:45 PST
PR -
https://github.com/WebKit/WebKit/pull/7320
Radar WebKit Bug Importer
Comment 2
2022-12-08 13:10:50 PST
<
rdar://problem/103143565
>
Ahmad Saleem
Comment 3
2022-12-08 13:12:09 PST
Ryosuke mentioned on PR that we cannot remove this code right now but if you want to see the patch and code, which I am removing and do it in future. You can do follow my PR link. I will close my PR now. Thanks! @rniwa - thanks for your support. Just ping me, in future, if you want me to remove this. :-)
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug