248627 – Remove EditingAppleTabSpan class handling

Bug 248627 - Remove EditingAppleTabSpan class handling

Summary: Remove EditingAppleTabSpan class handling

Status:	NEW

Alias:	None

Product:	WebKit
Classification:	Unclassified
Component:	HTML Editing (show other bugs)
Version:	Safari Technology Preview
Hardware:	Unspecified Unspecified

Importance:	P2 Normal
Assignee:	Nobody

URL:
Keywords:	InRadar

Depends on:
Blocks:

Reported:	2022-12-01 13:02 PST by Ahmad Saleem
Modified:	2023-10-21 00:26 PDT (History)
CC List:	4 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Ahmad Saleem 2022-12-01 13:02:02 PST

Hi Team,

While going through Blink's commit, I came across another about removing old code:

Blink Code - https://chromium.googlesource.com/chromium/src.git/+/013ac5eaf30c02dfa356ba5399da43eb9f368040

Webkit GitHub Source (Example) - https://github.com/WebKit/WebKit/blob/bb23e4eae6409a6dc22a4499c3ac9bdf7a4e56df/Source/WebCore/editing/HTMLInterchange.h#L41 & https://github.com/WebKit/WebKit/blob/bb23e4eae6409a6dc22a4499c3ac9bdf7a4e56df/Source/WebCore/editing/Editing.cpp#L804 & https://github.com/WebKit/WebKit/blob/bb23e4eae6409a6dc22a4499c3ac9bdf7a4e56df/Source/WebCore/editing/Editing.cpp#L823 & https://github.com/WebKit/WebKit/blob/bb23e4eae6409a6dc22a4499c3ac9bdf7a4e56df/Source/WebCore/editing/ReplaceSelectionCommand.cpp#L1075

Just wanted to raise bug to remove it after input from others that it is not used internally and we can remove it safely.

Thanks!

Comment 1 Radar WebKit Bug Importer 2022-12-08 13:02:15 PST

<rdar://problem/103143134>

Comment 2 Ryosuke Niwa 2022-12-08 13:05:14 PST

createTabSpanElement is still used. We can't remove this code yet.

Comment 3 Ahmad Saleem 2022-12-16 14:47:39 PST

NOTE - This causes regression and it was fixed in Blink with this commit - https://chromium.googlesource.com/chromium/src.git/+/52d55d36c78e4772e0e3499409dc6f6dcabde00e