WebKit Bugzilla
New
Browse
Search+
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
NEW
248627
Remove EditingAppleTabSpan class handling
https://bugs.webkit.org/show_bug.cgi?id=248627
Summary
Remove EditingAppleTabSpan class handling
Ahmad Saleem
Reported
2022-12-01 13:02:02 PST
Hi Team, While going through Blink's commit, I came across another about removing old code: Blink Code -
https://chromium.googlesource.com/chromium/src.git/+/013ac5eaf30c02dfa356ba5399da43eb9f368040
Webkit GitHub Source (Example) -
https://github.com/WebKit/WebKit/blob/bb23e4eae6409a6dc22a4499c3ac9bdf7a4e56df/Source/WebCore/editing/HTMLInterchange.h#L41
&
https://github.com/WebKit/WebKit/blob/bb23e4eae6409a6dc22a4499c3ac9bdf7a4e56df/Source/WebCore/editing/Editing.cpp#L804
&
https://github.com/WebKit/WebKit/blob/bb23e4eae6409a6dc22a4499c3ac9bdf7a4e56df/Source/WebCore/editing/Editing.cpp#L823
&
https://github.com/WebKit/WebKit/blob/bb23e4eae6409a6dc22a4499c3ac9bdf7a4e56df/Source/WebCore/editing/ReplaceSelectionCommand.cpp#L1075
Just wanted to raise bug to remove it after input from others that it is not used internally and we can remove it safely. Thanks!
Attachments
Add attachment
proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1
2022-12-08 13:02:15 PST
<
rdar://problem/103143134
>
Ryosuke Niwa
Comment 2
2022-12-08 13:05:14 PST
createTabSpanElement is still used. We can't remove this code yet.
Ahmad Saleem
Comment 3
2022-12-16 14:47:39 PST
NOTE - This causes regression and it was fixed in Blink with this commit -
https://chromium.googlesource.com/chromium/src.git/+/52d55d36c78e4772e0e3499409dc6f6dcabde00e
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug