Bug 248621 - [css-grid] Move collectMasonryItems responsibility from RenderGrid to GridMasonryLayout
Summary: [css-grid] Move collectMasonryItems responsibility from RenderGrid to GridMas...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-12-01 12:13 PST by Sammy Gill
Modified: 2022-12-04 12:11 PST (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sammy Gill 2022-12-01 12:13:37 PST 
There is not really a good reason to have this logic here instead of GridMasonryLayout. This would actually make it easier to reference items within these data structures (especially first track items) much more easily during the actual masonry layout algorithm
Comment 1 Radar WebKit Bug Importer 2022-12-01 12:14:02 PST 
<rdar://problem/102871735>
Comment 2 Sammy Gill 2022-12-01 16:07:42 PST 
Pull request: https://github.com/WebKit/WebKit/pull/7054
Comment 3 EWS 2022-12-04 12:11:40 PST 
Committed 257358@main (ee553c43b364): <https://commits.webkit.org/257358@main>

Reviewed commits have been landed. Closing PR #7054 and removing active labels.