248564 – Refactor RenderBox:sizesLogicalWidthToFitContent()

NEW248564

Refactor RenderBox:sizesLogicalWidthToFitContent()

https://bugs.webkit.org/show_bug.cgi?id=248564

Summary Refactor RenderBox:sizesLogicalWidthToFitContent()

Ahmad Saleem

Reported 2022-11-30 15:30:49 PST

Hi Team, While going through Blink Commit, I came across following refactoring to remove comment and logic, which was not clear. Blink Commit - https://src.chromium.org/viewvc/blink?revision=170695&view=revision Webkit GitHub - https://github.com/WebKit/WebKit/blob/8e087fe5157f63a97276f5f3155ff14974929491/Source/WebCore/rendering/RenderBox.cpp#L2740 & https://github.com/WebKit/WebKit/blob/8e087fe5157f63a97276f5f3155ff14974929491/Source/WebCore/rendering/RenderBox.cpp#L2812 & https://github.com/WebKit/WebKit/blob/8e087fe5157f63a97276f5f3155ff14974929491/Source/WebCore/rendering/RenderBox.cpp#L2822 and https://github.com/WebKit/WebKit/blob/8e087fe5157f63a97276f5f3155ff14974929491/Source/WebCore/rendering/RenderBox.h#L458 It will remove comment about being strange code. Just wanted to raise this bug so it can be tried. Thanks!

Attachments
Add attachment proposed patch, testcase, etc.

Radar WebKit Bug Importer

Comment 1 2022-12-07 15:31:18 PST

<rdar://problem/103092634>

Ahmad Saleem

Comment 2 2023-10-03 11:34:45 PDT

It fails here: https://searchfox.org/wubkat/source/Source/WebCore/dom/Document.cpp#2478 with following error: reference to type 'const Length' could not bind to an rvalue of type 'WebCore::SizeType' ...currRenderer->needsLayout() && currentBox->sizesLogicalWidthToFitContent(MainOrPreferredSize)))

Note You need to log in before you can comment on or make changes to this bug.

Status NEW

Resolution

Priority P2

Severity Normal

Classification Unclassified

Version Safari Technology Preview

Hardware Unspecified

OS Unspecified

Product WebKit

Component Layout and Rendering

Assignee

Nobody

Reported

2022-11-30 15:30 PST

Modified

2023-10-03 11:34 PDT History

CC List

4 users Show

URL

Keywords InRadar

Depends on

Blocks