Bug 248560 - [ANGLE] Don't run Adjust ANGLE Paths on every build
Summary: [ANGLE] Don't run Adjust ANGLE Paths on every build
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: ANGLE (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Dan Glastonbury
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-11-30 14:50 PST by Dan Glastonbury
Modified: 2022-11-30 15:00 PST (History)
4 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dan Glastonbury 2022-11-30 14:50:17 PST 
Xcode prints a warning that "Adjust ANGLE Paths" runs on every build invocation
because no outputPaths are provided. This change updates the rule to touch a
temporary file once it's completed so the rule has an outputPath to check,
disabling the warning.
Comment 1 Radar WebKit Bug Importer 2022-11-30 14:50:31 PST 
<rdar://problem/102830463>
Comment 2 Dan Glastonbury 2022-11-30 14:59:11 PST 
Pull request: https://github.com/WebKit/WebKit/pull/6993
Comment 3 Kenneth Russell 2022-11-30 15:00:18 PST 
In the past it was important for this script to be side-effect-free in the situation where the contents of the adjusted header files were unchanged. Otherwise a large number of source files would be unnecessarily recompiled during incremental builds. This is just a heads up for a scenario to test with any changes to the script's behavior.