Bug 248552 - AX: Make accessibility/mac/input-slider.html await dynamic page changes so it can pass in ITM
Summary: AX: Make accessibility/mac/input-slider.html await dynamic page changes so it...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Accessibility (show other bugs)
Version: Other
Hardware: All All
: P2 Normal
Assignee: Tyler Wilcock
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-11-30 13:31 PST by Tyler Wilcock
Modified: 2022-12-03 01:48 PST (History)
10 users (show)

See Also:

Attachments
Patch (13.86 KB, patch)
2022-11-30 13:35 PST, Tyler Wilcock 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tyler Wilcock 2022-11-30 13:31:01 PST 
AX: Make accessibility/mac/input-slider.html await dynamic page changes so it can pass in ITM
Comment 1 Radar WebKit Bug Importer 2022-11-30 13:31:15 PST 
<rdar://problem/102827179>
Comment 2 Tyler Wilcock 2022-11-30 13:35:03 PST 
Created attachment 463815 [details]
Patch
Comment 3 Andres Gonzalez 2022-12-01 07:28:57 PST 
(In reply to Tyler Wilcock from comment #2)
> Created attachment 463815 [details]
> Patch

+    var slider = document.getElementById("slider");
+    var sliderAXObject = accessibilityController.accessibleElementById("slider");

In cases like this, can we just call the AX object variable like axSlider? i.e., the DOM element foo and the AX object axFoo.
Comment 4 EWS 2022-12-02 11:49:10 PST 
Committed 257297@main (75825c6ed268): <https://commits.webkit.org/257297@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 463815 [details].
Comment 5 Tyler Wilcock 2022-12-03 01:48:10 PST 
(In reply to Andres Gonzalez from comment #3)
> (In reply to Tyler Wilcock from comment #2)
> > Created attachment 463815 [details]
> > Patch
> 
> +    var slider = document.getElementById("slider");
> +    var sliderAXObject =
> accessibilityController.accessibleElementById("slider");
> 
> In cases like this, can we just call the AX object variable like axSlider?
> i.e., the DOM element foo and the AX object axFoo.
Oops, forgot to respond to this. Definitely agree — sliderAXObject was the name in the  existing version of the test, but will follow this naming scheme for future patches.