Bug 248502 - Manually invalidate the FontCache before clearing ThreadGlobalData.
Summary: Manually invalidate the FontCache before clearing ThreadGlobalData.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Matt Woodrow
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-11-29 15:34 PST by Matt Woodrow
Modified: 2022-11-29 20:58 PST (History)
4 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Matt Woodrow 2022-11-29 15:34:17 PST 
Destructing the FontCache can recurse back into the ThreadGlobalData getter (to remove cached entries), so
we want to manually clear the FontCache before clearing the ThreadGlobalData pointer.

This also moves m_destroyed to earlier in the class, so it's guaranteed to be destructed after m_fontCache.
Comment 1 Matt Woodrow 2022-11-29 15:39:32 PST 
Pull request: https://github.com/WebKit/WebKit/pull/6948
Comment 2 EWS 2022-11-29 20:57:39 PST 
Committed 257160@main (2d8a9204f770): <https://commits.webkit.org/257160@main>

Reviewed commits have been landed. Closing PR #6948 and removing active labels.