Bug 248486 - Potential crash fix by bailing from DeleteSelectionCommand::doApply when selection isn't editable
Summary: Potential crash fix by bailing from DeleteSelectionCommand::doApply when sele...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: HTML Editing (show other bugs)
Version: Safari Technology Preview
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-11-29 12:19 PST by Ahmad Saleem
Modified: 2022-11-30 16:41 PST (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ahmad Saleem 2022-11-29 12:19:46 PST 
Hi Team,

While going through Blink's commit, I found another potential merge, which can make Webkit more stable and not hit situation leading to crash on debug or release builds:

Blink Commit - https://src.chromium.org/viewvc/blink?view=revision&revision=190121

Webkit GitHub Source - https://github.com/WebKit/WebKit/blob/7e26ee98dc891f869c003c1724f061a82d65bd2b/Source/WebCore/editing/DeleteSelectionCommand.cpp#L984

This is to avoid any crash and harden the function.

Thanks!
Comment 1 EWS 2022-11-30 16:40:51 PST 
Committed 257203@main (b83027e6d7d0): <https://commits.webkit.org/257203@main>

Reviewed commits have been landed. Closing PR #6932 and removing active labels.
Comment 2 Radar WebKit Bug Importer 2022-11-30 16:41:17 PST 
<rdar://problem/102835623>