Bug 248482 - AX: add to AXLogger the ability to filter the output by keywords.
Summary: AX: add to AXLogger the ability to filter the output by keywords.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Accessibility (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Andres Gonzalez
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-11-29 11:12 PST by Andres Gonzalez
Modified: 2022-11-30 18:40 PST (History)
10 users (show)

See Also:

Attachments
Patch (9.03 KB, patch)
2022-11-29 11:18 PST, Andres Gonzalez 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (9.13 KB, patch)
2022-11-29 12:48 PST, Andres Gonzalez 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andres Gonzalez 2022-11-29 11:12:19 PST 
At the moment you get either all or none, you can only filter by thread.
Comment 1 Radar WebKit Bug Importer 2022-11-29 11:12:33 PST 
<rdar://problem/102775230>
Comment 2 Andres Gonzalez 2022-11-29 11:18:51 PST 
Created attachment 463791 [details]
Patch
Comment 3 Andres Gonzalez 2022-11-29 12:48:59 PST 
Created attachment 463793 [details]
Patch
Comment 4 chris fleizach 2022-11-30 13:56:57 PST 
Comment on attachment 463793 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=463793&action=review

> Source/WebCore/accessibility/AXLogger.cpp:59
> +        auto it = std::find_if(nameFilter->begin(), nameFilter->end(), [this] (const auto& name) {

can you choose a more descriptive variable name (instead of 'it')
Comment 5 EWS 2022-11-30 18:40:12 PST 
Committed 257212@main (d6d9cf06a048): <https://commits.webkit.org/257212@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 463793 [details].