NEW248479
Allow _target argument to shouldBeCloseTo to be a string to eval 
https://bugs.webkit.org/show_bug.cgi?id=248479
Summary Allow _target argument to shouldBeCloseTo to be a string to eval
Ahmad Saleem
Reported 2022-11-29 10:49:23 PST
Hi Team, While going through Blink's commit, I came across this to update 'js-test.js' to make it more error proof. Blink Commit - https://chromium.googlesource.com/chromium/blink/+/14fd02d3d15e26cfccf048e175ab4b0e7e928b43%5E%21/#F0 I just wanted to raise this bug to get opinion whether it is worth merging or not. Thanks!
Attachments
Add attachment proposed patch, testcase, etc.
Alexey Proskuryakov
Comment 1 2022-11-29 12:42:43 PST
Seems like a nice improvement in principle. Two comments: - We have more than one copy of shouldBeCloseTo(), would want to update them all. - The change in itself doesn't change anything observable, so it's largely pointless unless some tests take advantage of the new functionality.
Radar WebKit Bug Importer
Comment 2 2022-12-08 12:33:09 PST
<rdar://problem/103141617>
Note You need to log in before you can comment on or make changes to this bug.