Bug 248479 - Allow _target argument to shouldBeCloseTo to be a string to eval
Summary: Allow _target argument to shouldBeCloseTo to be a string to eval
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: Safari Technology Preview
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-11-29 10:49 PST by Ahmad Saleem
Modified: 2022-12-08 12:33 PST (History)
3 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ahmad Saleem 2022-11-29 10:49:23 PST 
Hi Team,

While going through Blink's commit, I came across this to update 'js-test.js' to make it more error proof.

Blink Commit - https://chromium.googlesource.com/chromium/blink/+/14fd02d3d15e26cfccf048e175ab4b0e7e928b43%5E%21/#F0

I just wanted to raise this bug to get opinion whether it is worth merging or not.

Thanks!
Comment 1 Alexey Proskuryakov 2022-11-29 12:42:43 PST 
Seems like a nice improvement in principle. Two comments:
- We have more than one copy of shouldBeCloseTo(), would want to update them all.
- The change in itself doesn't change anything observable, so it's largely pointless unless some tests take advantage of the new functionality.
Comment 2 Radar WebKit Bug Importer 2022-12-08 12:33:09 PST 
<rdar://problem/103141617>