Bug 248448 - [leading-trim] Add support for parsing "text-edge" CSS property
Summary: [leading-trim] Add support for parsing "text-edge" CSS property
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords: InRadar
Depends on: 248612
Blocks: 245599
  Show dependency tree / graph
 
Reported: 2022-11-28 17:21 PST by zalan
Modified: 2023-01-13 09:28 PST (History)
20 users (show)

See Also:

Attachments
Patch (24.95 KB, patch)
2022-11-28 17:38 PST, zalan 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (25.08 KB, patch)
2022-11-28 18:19 PST, zalan 		no flags Details | Formatted Diff | Diff
Patch (25.66 KB, patch)
2022-11-28 20:52 PST, zalan 		no flags Details | Formatted Diff | Diff
Patch (33.29 KB, patch)
2022-11-29 11:00 PST, zalan 		no flags Details | Formatted Diff | Diff
[fast-cq]Patch (37.60 KB, patch)
2022-11-30 12:37 PST, zalan 		no flags Details | Formatted Diff | Diff
Patch (38.24 KB, patch)
2022-12-01 14:08 PST, zalan 		no flags Details | Formatted Diff | Diff
Show Obsolete (5) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2022-11-28 17:21:52 PST 
ssia
Comment 1 zalan 2022-11-28 17:38:37 PST 
Created attachment 463775 [details]
Patch
Comment 2 zalan 2022-11-28 18:19:39 PST 
Created attachment 463776 [details]
Patch
Comment 3 zalan 2022-11-28 20:52:56 PST 
Created attachment 463778 [details]
Patch
Comment 4 zalan 2022-11-29 11:00:24 PST 
Created attachment 463790 [details]
Patch
Comment 5 zalan 2022-11-30 12:37:56 PST 
Created attachment 463812 [details]
[fast-cq]Patch
Comment 6 EWS 2022-12-01 06:12:19 PST 
Committed 257233@main (5cecbfbd8605): <https://commits.webkit.org/257233@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 463812 [details].
Comment 7 Radar WebKit Bug Importer 2022-12-01 06:13:18 PST 
<rdar://problem/102858086>
Comment 8 WebKit Commit Bot 2022-12-01 09:58:16 PST 
Re-opened since this is blocked by bug 248612
Comment 9 zalan 2022-12-01 14:08:04 PST 
Created attachment 463843 [details]
Patch
Comment 10 EWS 2022-12-02 12:40:24 PST 
Committed 257306@main (271f21cba431): <https://commits.webkit.org/257306@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 463843 [details].
Comment 11 Oriol Brufau 2022-12-02 21:35:42 PST 
cssom-getPropertyValue-common-checks.html was rightly complaining that getComputedStyle().textEdge returns "leading leading", which is not accepted by the parser.

Instead of adding this to the list of existing failures, it would have been better to fix the parser or the serialization.