Bug 248434 - Potential Crash fix by not propagating empty value for face attribute
Summary: Potential Crash fix by not propagating empty value for face attribute
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: Safari Technology Preview
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-11-28 15:33 PST by Ahmad Saleem
Modified: 2022-12-01 11:53 PST (History)
5 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ahmad Saleem 2022-11-28 15:33:35 PST 
Hi Team,

While going through Blink's commit, I came across following crash fix, which can be applied to Webkit:

Blink Commit - https://src.chromium.org/viewvc/blink?view=revision&revision=190788

Webkit GitHub Source - https://github.com/WebKit/WebKit/blob/b9824fc290ac9247e8a04f38632a8fdd4b9ec02d/Source/WebCore/html/HTMLFontElement.cpp#L193

Safari does not crash with the test case but I think it would be good to be safe.

I will let others to confirm whether we should merge this or not.

Thanks!
Comment 1 Ahmad Saleem 2022-11-30 04:24:27 PST 
https://github.com/WebKit/WebKit/pull/6964
Comment 2 EWS 2022-12-01 11:52:31 PST 
Committed 257248@main (7f50b6d09b38): <https://commits.webkit.org/257248@main>

Reviewed commits have been landed. Closing PR #6964 and removing active labels.
Comment 3 Radar WebKit Bug Importer 2022-12-01 11:53:19 PST 
<rdar://problem/102870770>