Bug 248413 - Fix caret move by line when padding-top is set
Summary: Fix caret move by line when padding-top is set
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: HTML Editing (show other bugs)
Version: Safari Technology Preview
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: BrowserCompat, InRadar
Depends on:
Blocks:
 
Reported: 2022-11-28 11:51 PST by Ahmad Saleem
Modified: 2023-02-06 12:06 PST (History)
3 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ahmad Saleem 2022-11-28 11:51:58 PST 
Hi Team,

While going through Blink's commit, I came across another commit, where the testcase is failing two on Safari Technology Preview 158 compared to other browsers (Chrome Canary 110 and Firefox Nightly 109):

Blink Commit - https://chromium.googlesource.com/chromium/blink/+/87805d6f9313997171b970d847e141a18b95dcf7

Test Case (Failing two) - https://jsfiddle.net/0dufm2eb/show

I haven't explored whether it could be 1-1 merge possible but just wanted to raise for tracking in future.

Thanks!
Comment 1 Radar WebKit Bug Importer 2022-12-05 11:52:20 PST 
<rdar://problem/102991672>
Comment 2 Ahmad Saleem 2023-02-02 09:53:54 PST 
It is partial merge and on local testing while only fixing VisibleUnits.cpp / h, this test case passes.
Comment 3 Ahmad Saleem 2023-02-02 10:13:02 PST 
PR - https://github.com/WebKit/WebKit/pull/9534

Let's give it a try.
Comment 4 EWS 2023-02-06 12:06:23 PST 
Committed 259906@main (7e9c27142b2f): <https://commits.webkit.org/259906@main>

Reviewed commits have been landed. Closing PR #9534 and removing active labels.