Bug 248394 - Remove KeyboardEvent.altGraphKey
Summary: Remove KeyboardEvent.altGraphKey
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: UI Events (show other bugs)
Version: Safari Technology Preview
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-11-28 06:46 PST by Ahmad Saleem
Modified: 2024-01-23 16:12 PST (History)
5 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Ahmad Saleem 2022-11-28 06:46:41 PST
Hi Team,

Just going through Blink's commit, I came across another, which if needed, we can merge to remove "KeyboardEvent.altGraphKey":

Blink Commit - https://src.chromium.org/viewvc/blink?view=revision&revision=179545

It was Webkit only attribute and it is now removed from Blink as well.

It seems that we still have this - https://github.com/WebKit/WebKit/blob/3a4c0cbdfa7b088c28fcb57dd3a1c5889af5c58a/Source/WebCore/dom/KeyboardEvent.cpp#L166

Just wanted to raise this bug.

Thanks!
Comment 1 Ryosuke Niwa 2022-11-28 11:19:03 PST
This flag might to be in use at first glance:
https://github.com/search?q=altGraphKey+language%3AJavaScript&type=code&l=JavaScript
Comment 2 Radar WebKit Bug Importer 2022-12-05 06:47:15 PST
<rdar://problem/102980723>
Comment 3 Ahmad Saleem 2022-12-05 07:11:56 PST
(In reply to Ryosuke Niwa from comment #1)
> This flag might to be in use at first glance:
> https://github.com/
> search?q=altGraphKey+language%3AJavaScript&type=code&l=JavaScript

Cool! I just raised it since it mentioned that it was Webkit only and non-standard and returns always "false". Still good to track for future purposes.
Comment 4 Tim Nguyen (:ntim) 2023-01-04 21:09:15 PST
(In reply to Ryosuke Niwa from comment #1)
> This flag might to be in use at first glance:
> https://github.com/
> search?q=altGraphKey+language%3AJavaScript&type=code&l=JavaScript

If it's always false in WebKit, there shouldn't be any fallout. All the usages from that search are in checks. After removing, altGraphKey will be undefined, which is still falsy.
Comment 5 Ahmad Saleem 2023-11-22 10:59:50 PST
Just came across this from another bug, using this test case:

https://guacamole.apache.org/pub/tests/key-event-test.html

Pressing any key - altGraphKey is 'undefined' for Firefox & Chrome while 'false' for Safari.
Comment 6 Ahmad Saleem 2024-01-20 18:22:53 PST
PR - https://github.com/WebKit/WebKit/pull/23015
Comment 7 EWS 2024-01-23 16:12:37 PST
Committed 273379@main (f1f9f0045afe): <https://commits.webkit.org/273379@main>

Reviewed commits have been landed. Closing PR #23015 and removing active labels.