Bug 248386 - Remove StyleProperties::textDecorationSkipValue()
Summary: Remove StyleProperties::textDecorationSkipValue()
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tim Nguyen (:ntim)
URL:
Keywords: InRadar
Depends on:
Blocks: 248383
  Show dependency tree / graph
 
Reported: 2022-11-28 01:08 PST by Tim Nguyen (:ntim)
Modified: 2022-11-28 04:44 PST (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Nguyen (:ntim) 2022-11-28 01:08:31 PST 
text-decoration-skip can share the serialization handling with other shorthands with single longhands.

We don't ever need to serialize `ink` because it gets changed to `auto` anyway at parse-time.

We also don't need to take care of implicit property references, since we never add text-decoration-skip-ink as implicit in `consumeTextDecorationSkip()`.
Comment 1 Radar WebKit Bug Importer 2022-11-28 01:08:43 PST 
<rdar://problem/102708232>
Comment 2 Tim Nguyen (:ntim) 2022-11-28 01:12:09 PST 
Pull request: https://github.com/WebKit/WebKit/pull/6851
Comment 3 EWS 2022-11-28 04:44:13 PST 
Committed 257067@main (b564ed1fb7d6): <https://commits.webkit.org/257067@main>

Reviewed commits have been landed. Closing PR #6851 and removing active labels.