Bug 248380 - Unreviewed build fix for PlayStation
Summary: Unreviewed build fix for PlayStation
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ross Kirsling
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-11-27 19:02 PST by Ross Kirsling
Modified: 2022-11-27 21:17 PST (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ross Kirsling 2022-11-27 19:02:06 PST 
Unreviewed build fix for PlayStation
Comment 1 Ross Kirsling 2022-11-27 19:03:11 PST 
Pull request: https://github.com/WebKit/WebKit/pull/6846
Comment 2 EWS 2022-11-27 19:06:29 PST 
Committed 257056@main (675d141bdcf7): <https://commits.webkit.org/257056@main>

Reviewed commits have been landed. Closing PR #6846 and removing active labels.
Comment 3 Radar WebKit Bug Importer 2022-11-27 19:07:16 PST 
<rdar://problem/102701329>
Comment 4 Alexey Proskuryakov 2022-11-27 20:05:22 PST 
This is not quite right. WTF should never need prefixes at call sites, all symbols that are expected to be used outside WTF need to be exported with `using`.
Comment 5 Ross Kirsling 2022-11-27 21:17:52 PST 
(In reply to Alexey Proskuryakov from comment #4)
> This is not quite right. WTF should never need prefixes at call sites, all
> symbols that are expected to be used outside WTF need to be exported with
> `using`.

This change is a fix for https://github.com/WebKit/WebKit/commit/b1f94e7ba1ccdedaa103189b6979a9839a6cdcec, such that the newly-added ArgumentCodersUnix.h is in alignment with the existing ArgumentCodersDarwin.h and ArgumentCodersWin.h.