Bug 248361 - Potential Crash fix by not allowing editing to remove PseudoElements
Summary: Potential Crash fix by not allowing editing to remove PseudoElements
Status: RESOLVED INVALID
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: Safari Technology Preview
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-11-26 07:23 PST by Ahmad Saleem
Modified: 2022-11-28 12:12 PST (History)
1 user (show)

See Also:

Attachments
Test case (1.08 KB, text/html)
2022-11-28 12:11 PST, Ryosuke Niwa 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ahmad Saleem 2022-11-26 07:23:40 PST 
Hi Team,

While going through Blink commits, I came across another potential crash fix, which can be applied:

Blink Commit - https://src.chromium.org/viewvc/blink?view=revision&revision=166985

Webkit GitHub Source - https://github.com/WebKit/WebKit/blob/f0e70ac5078d742d598da042f4728d042aca3e98/Source/WebCore/dom/ContainerNode.cpp#LL659 & for PseudoElement.cpp, there might be case to add new function.

Just wanted to raise to confirm whether we need to merge this or not.

Thanks!
Comment 1 Ryosuke Niwa 2022-11-28 12:11:44 PST 
Created attachment 463767 [details]
Test case
Comment 2 Ryosuke Niwa 2022-11-28 12:12:08 PST 
The test doesn't reproduce a crash in WebKit.