Bug 248351 - [IFC][Text combine] Not all RenderCombineText renderers are combined
Summary: [IFC][Text combine] Not all RenderCombineText renderers are combined
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords: InRadar
Depends on:
Blocks: 248353
  Show dependency treegraph
 
Reported: 2022-11-25 16:49 PST by zalan
Modified: 2022-11-26 07:45 PST (History)
6 users (show)

See Also:


Attachments
[fast-cq]Patch (1.67 KB, patch)
2022-11-25 16:53 PST, zalan
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2022-11-25 16:49:20 PST
ssia
Comment 1 zalan 2022-11-25 16:53:25 PST
Created attachment 463736 [details]
[fast-cq]Patch
Comment 2 Tim Nguyen (:ntim) 2022-11-25 17:29:22 PST
Comment on attachment 463736 [details]
[fast-cq]Patch

(fwiw, according to the spec, text should always combine, even if it doesn't fit, we should squash it to fit in 1em like FF/Chrome do (even if that makes it unreadable))
Comment 3 zalan 2022-11-25 17:35:50 PST
(In reply to Tim Nguyen (:ntim) from comment #2)
> Comment on attachment 463736 [details]
> Patch
> 
> (fwiw, according to the spec, text should always combine, even if it doesn't
> fit, we should squash it to fit in 1em like FF/Chrome do (even if that makes
> it unreadable))
please file a bug. this is merely an integration patch.
Comment 4 zalan 2022-11-25 17:45:45 PST
we are certainly not spec compliant here by ignoring the property when we can't find sufficient way to represent the content -not sure what the point of rendering the content unreadable, but I guess that had been debated and settled already.
Comment 5 Tim Nguyen (:ntim) 2022-11-25 20:33:36 PST
(In reply to zalan from comment #3)
> (In reply to Tim Nguyen (:ntim) from comment #2)
> > Comment on attachment 463736 [details]
> > Patch
> > 
> > (fwiw, according to the spec, text should always combine, even if it doesn't
> > fit, we should squash it to fit in 1em like FF/Chrome do (even if that makes
> > it unreadable))
> please file a bug. this is merely an integration patch.

Bug 234704 and bug 164510 have been filed for a while.
Comment 6 EWS 2022-11-26 07:44:53 PST
Committed 257035@main (0e6ff995b669): <https://commits.webkit.org/257035@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 463736 [details].
Comment 7 Radar WebKit Bug Importer 2022-11-26 07:45:17 PST
<rdar://problem/102681412>