Bug 248343 - REGRESSION(256830@main): Fix WebRTC cmake build after usrsctp removal
Summary: REGRESSION(256830@main): Fix WebRTC cmake build after usrsctp removal
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebRTC (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-11-25 07:58 PST by Olivier Blin
Modified: 2022-12-09 10:46 PST (History)
4 users (show)

See Also:

Attachments
Mac platform changes (4.16 KB, patch)
2022-11-28 05:52 PST, Olivier Blin 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Olivier Blin 2022-11-25 07:58:02 PST 
In 256830@main, the usrsctp third party has been removed from WebRTC, but the cmake files have not been updated.

This was ok in the first pull request: https://github.com/WebKit/WebKit/pull/5070
But it has been missed in the second one: https://github.com/WebKit/WebKit/pull/6584
Comment 1 Olivier Blin 2022-11-25 07:59:33 PST 
Pull request: https://github.com/WebKit/WebKit/pull/6816
Comment 2 Philippe Normand 2022-11-27 02:33:11 PST 

*** This bug has been marked as a duplicate of bug 248336 ***
Comment 3 Olivier Blin 2022-11-28 05:52:50 PST 
Created attachment 463754 [details]
Mac platform changes

I guess the Mac platform still needs the PlatformMac.cmake change.
Should I reopen the bug just to fix this one and remove the WEBRTC_HAVE_USRSCTP define?

Attached is what remains from my patch.
Comment 4 Philippe Normand 2022-11-28 05:56:25 PST 
Ah yes, please submit a new PR, I'm reopening this bug :)
Comment 5 Olivier Blin 2022-11-30 14:14:27 PST 
Pull request: https://github.com/WebKit/WebKit/pull/6988
Comment 6 EWS 2022-12-09 10:45:35 PST 
Committed 257637@main (a0968d750159): <https://commits.webkit.org/257637@main>

Reviewed commits have been landed. Closing PR #6988 and removing active labels.
Comment 7 Radar WebKit Bug Importer 2022-12-09 10:46:19 PST 
<rdar://problem/103186359>