Bug 248336 - [GTK] Build error when budiling with LibWebRTC support after 256830@main
Summary: [GTK] Build error when budiling with LibWebRTC support after 256830@main
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Diego Pino
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-11-25 00:45 PST by Diego Pino
Modified: 2022-11-27 02:33 PST (History)
4 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Diego Pino 2022-11-25 00:45:55 PST 
[256830@main](https://github.com/WebKit/WebKit/pull/6584) removed WebRTC third party usrsctp but there are still references to this library in LibWebRTC's CMakeLists.txt.

https://github.com/WebKit/WebKit/blob/main/Source/ThirdParty/libwebrtc/CMakeLists.txt#L2084

```
Source/third_party/usrsctp/usrsctplib/usrsctplib/netinet/sctp_asconf.c
Source/third_party/usrsctp/usrsctplib/usrsctplib/netinet/sctp_auth.c
Source/third_party/usrsctp/usrsctplib/usrsctplib/netinet/sctp_bsd_addr.c
Source/third_party/usrsctp/usrsctplib/usrsctplib/netinet/sctp_callout.c
Source/third_party/usrsctp/usrsctplib/usrsctplib/netinet/sctp_cc_functions.c
Source/third_party/usrsctp/usrsctplib/usrsctplib/netinet/sctp_crc32.c
Source/third_party/usrsctp/usrsctplib/usrsctplib/netinet/sctp_indata.c
Source/third_party/usrsctp/usrsctplib/usrsctplib/netinet/sctp_input.c
Source/third_party/usrsctp/usrsctplib/usrsctplib/netinet/sctp_output.c
Source/third_party/usrsctp/usrsctplib/usrsctplib/netinet/sctp_pcb.c
Source/third_party/usrsctp/usrsctplib/usrsctplib/netinet/sctp_peeloff.c
Source/third_party/usrsctp/usrsctplib/usrsctplib/netinet/sctp_sha1.c
Source/third_party/usrsctp/usrsctplib/usrsctplib/netinet/sctp_ss_functions.c
Source/third_party/usrsctp/usrsctplib/usrsctplib/netinet/sctp_sysctl.c
Source/third_party/usrsctp/usrsctplib/usrsctplib/netinet/sctp_timer.c
Source/third_party/usrsctp/usrsctplib/usrsctplib/netinet/sctp_userspace.c
Source/third_party/usrsctp/usrsctplib/usrsctplib/netinet/sctp_usrreq.c
Source/third_party/usrsctp/usrsctplib/usrsctplib/netinet/sctputil.c
Source/third_party/usrsctp/usrsctplib/usrsctplib/netinet6/sctp6_usrreq.c
Source/third_party/usrsctp/usrsctplib/usrsctplib/user_environment.c
Source/third_party/usrsctp/usrsctplib/usrsctplib/user_mbuf.c
Source/third_party/usrsctp/usrsctplib/usrsctplib/user_recv_thread.c
Source/third_party/usrsctp/usrsctplib/usrsctplib/user_socket.c
```
Comment 1 Diego Pino 2022-11-25 01:45:15 PST 
Pull request: https://github.com/webkit/webkit/pull/6808
Comment 2 EWS 2022-11-25 05:46:26 PST 
Committed 257020@main (ee56f48f9734): <https://commits.webkit.org/257020@main>

Reviewed commits have been landed. Closing PR #6808 and removing active labels.
Comment 3 Radar WebKit Bug Importer 2022-11-25 05:47:18 PST 
<rdar://problem/102666167>
Comment 4 Philippe Normand 2022-11-27 02:33:11 PST 
*** Bug 248343 has been marked as a duplicate of this bug. ***