RESOLVED FIXED248311
Reuse the StylePropertyShorthand in StyleProperties::getPropertyValue() 
https://bugs.webkit.org/show_bug.cgi?id=248311
Summary Reuse the StylePropertyShorthand in StyleProperties::getPropertyValue()
Oriol Brufau
Reported 2022-11-24 09:04:27 PST
StyleProperties::getPropertyValue() has a big switch like this: switch (propertyID) { case CSSPropertyAll: return getCommonValue(allShorthand()); case CSSPropertyAnimation: return getLayeredShorthandValue(animationShorthand()); case CSSPropertyBorderSpacing: return borderSpacingValue(borderSpacingShorthand()); case CSSPropertyBackgroundPosition: return getLayeredShorthandValue(backgroundPositionShorthand()); case CSSPropertyBackground: return getLayeredShorthandValue(backgroundShorthand()); ... Most shorthands need to get the StylePropertyShorthand using allShorthand(), animationShorthand(), ... But before the switch it calls commonShorthandChecks(), which uses shorthandForProperty(propertyID) to get the StylePropertyShorthand. So this StylePropertyShorthand can be reused.
Attachments
Add attachment proposed patch, testcase, etc.
Oriol Brufau
Comment 1 2022-11-24 09:16:49 PST
Pull request: https://github.com/WebKit/WebKit/pull/6787
EWS
Comment 2 2022-11-25 00:56:09 PST
Committed 257011@main (70230d10f272): <https://commits.webkit.org/257011@main> Reviewed commits have been landed. Closing PR #6787 and removing active labels.
Radar WebKit Bug Importer
Comment 3 2022-11-25 00:57:19 PST
<rdar://problem/102659948>
Note You need to log in before you can comment on or make changes to this bug.