Bug 248289 - [CMake][Win] Use CMAKE_MSVC_RUNTIME_LIBRARY to select a CRT type instead of regexp replacing
Summary: [CMake][Win] Use CMAKE_MSVC_RUNTIME_LIBRARY to select a CRT type instead of r...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CMake (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Fujii Hironori
URL:
Keywords:
: 248246 (view as bug list)
Depends on:
Blocks: 248246
  Show dependency tree / graph
 
Reported: 2022-11-23 13:53 PST by Fujii Hironori
Modified: 2022-11-27 16:48 PST (History)
3 users (show)

See Also:

Attachments
Patch (6.20 KB, patch)
2022-11-23 16:21 PST, Fujii Hironori 		no flags Details | Formatted Diff | Diff
Patch (6.17 KB, patch)
2022-11-27 12:42 PST, Fujii Hironori 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Fujii Hironori 2022-11-23 13:53:47 PST 
[CMake][MSVC] Use CMAKE_MSVC_RUNTIME_LIBRARY to select a CRT type instead of regexp replacing

CMake 3.15 introduced CMP0091 and CMAKE_MSVC_RUNTIME_LIBRARY.

https://cmake.org/cmake/help/latest/policy/CMP0091.html
https://cmake.org/cmake/help/latest/variable/CMAKE_MSVC_RUNTIME_LIBRARY.html

AppleWin bots are using 3.21.3 (bug#231905 comment#2)
Comment 1 Fujii Hironori 2022-11-23 16:21:35 PST 
Created attachment 463699 [details]
Patch
Comment 2 Fujii Hironori 2022-11-23 16:49:02 PST 
Comment on attachment 463699 [details]
Patch

Umm, jsc EWS failed.

> CMake Error at Source/JavaScriptCore/CMakeLists.txt:2 (cmake_policy):
>   Policy "CMP0091" is not known to this version of CMake.
Comment 3 Don Olmstead 2022-11-26 17:52:41 PST 
Comment on attachment 463699 [details]
Patch

Bots are now happy so this is good to go
Comment 4 Fujii Hironori 2022-11-27 12:21:36 PST 
*** Bug 248246 has been marked as a duplicate of this bug. ***
Comment 5 Fujii Hironori 2022-11-27 12:42:52 PST 
Created attachment 463744 [details]
Patch
Comment 6 EWS 2022-11-27 16:48:22 PST 
Committed 257053@main (121756da7448): <https://commits.webkit.org/257053@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 463744 [details].