WebKit Bugzilla
New
Browse
Search+
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
248264
[WebXR] Disarm GCGLOwned object destructors when GraphicsContextGL is NULL
https://bugs.webkit.org/show_bug.cgi?id=248264
Summary
[WebXR] Disarm GCGLOwned object destructors when GraphicsContextGL is NULL
Dan Glastonbury
Reported
2022-11-23 00:24:38 PST
It's possible to destroy the underlying GraphicsContextGL before WebXROpaqueFramebuffer's destructor runs. For example, when creating too WebGL contexts, the context associated with a WebXROpaqueFramebuffer will be lost. The GCGLOwned objects exist to catch when the user forgets to clean up. In this case, where the GraphicsContextGL is NULL at destruction time, there's nothing to do but reset the GCGLOwned objects, preventing their destructors from asserting in debug builds.
Attachments
Add attachment
proposed patch, testcase, etc.
Dan Glastonbury
Comment 1
2022-11-23 00:25:20 PST
rdar://102173321
Dan Glastonbury
Comment 2
2022-11-23 00:29:48 PST
Pull request:
https://github.com/WebKit/WebKit/pull/6755
EWS
Comment 3
2022-11-23 18:32:46 PST
Committed
256981@main
(d2dc5ce72fbe): <
https://commits.webkit.org/256981@main
> Reviewed commits have been landed. Closing PR #6755 and removing active labels.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug