Bug 248254 - Fix return type of WTR::buildModifierFlags() in EventSenderProxy.mm
Summary: Fix return type of WTR::buildModifierFlags() in EventSenderProxy.mm
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: David Kilzer (:ddkilzer)
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-11-22 18:43 PST by David Kilzer (:ddkilzer)
Modified: 2022-11-23 06:54 PST (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description David Kilzer (:ddkilzer) 2022-11-22 18:43:08 PST 
Fix return type of WTR::buildModifierFlags() in EventSenderProxy.mm.

Currently uses `int` where `NSEventModifierFlags` should be used.

Regressed back in 2011 with commit 83922@main (r95039).
Comment 1 Radar WebKit Bug Importer 2022-11-22 18:43:22 PST 
<rdar://problem/102615921>
Comment 2 David Kilzer (:ddkilzer) 2022-11-22 18:45:12 PST 
Pull request: https://github.com/WebKit/WebKit/pull/6750
Comment 3 EWS 2022-11-23 06:54:10 PST 
Committed 256972@main (99718f07fd9a): <https://commits.webkit.org/256972@main>

Reviewed commits have been landed. Closing PR #6750 and removing active labels.