Bug 248246 - [CMake] Bump cmake_minimum_required version to 3.16
Summary: [CMake] Bump cmake_minimum_required version to 3.16
Status: RESOLVED DUPLICATE of bug 248289
Alias: None
Product: WebKit
Classification: Unclassified
Component: CMake (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Fujii Hironori
URL:
Keywords:
Depends on: 248289
Blocks: 248202
  Show dependency tree / graph
 
Reported: 2022-11-22 12:57 PST by Fujii Hironori
Modified: 2022-11-27 12:21 PST (History)
3 users (show)

See Also:

Attachments
Patch (2.70 KB, patch)
2022-11-22 13:12 PST, Fujii Hironori 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Fujii Hironori 2022-11-22 12:57:04 PST 
[CMake] Bump cmake_minimum_required version to 3.16.3

https://trac.webkit.org/wiki/WebKitGTK/DependenciesPolicy
https://packages.ubuntu.com/focal/cmake

See also:
  Bug 221727 – [CMake] Bump cmake_minimum_required version to 3.12 or later
Comment 1 Fujii Hironori 2022-11-22 13:12:51 PST 
Created attachment 463677 [details]
Patch
Comment 2 Don Olmstead 2022-11-22 13:28:19 PST 
Comment on attachment 463677 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=463677&action=review

> Source/JavaScriptCore/CMakeLists.txt:1
> +cmake_minimum_required(VERSION 3.16.3)

The feature you want to use is in 3.16 so I think you should use that as the minimum version not what the CMake version of the GTK policy is.
Comment 3 Fujii Hironori 2022-11-23 13:56:39 PST 
AppleWin EWS failed. I'm going to fix it in another bug.
  Bug 248289 – [CMake][MSVC] Use CMAKE_MSVC_RUNTIME_LIBRARY to select a CRT type instead of regexp replacing
Comment 4 Fujii Hironori 2022-11-27 12:21:36 PST 
I wanted to split patches, but it turned out that I should land both changes as a single commit. Merged this into bug#248289.

*** This bug has been marked as a duplicate of bug 248289 ***