WebKit Bugzilla
New
Browse
Search+
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
248238
[ews-app] Prevent uat instance from updating GitHub PRs
https://bugs.webkit.org/show_bug.cgi?id=248238
Summary
[ews-app] Prevent uat instance from updating GitHub PRs
Aakash Jain
Reported
2022-11-22 09:28:59 PST
There are multiple duplicate EWS comments on EWS PRs. e.g.: on PR
https://github.com/WebKit/WebKit/pull/6739
, there are two comments for same hash
https://github.com/WebKit/WebKit/pull/6739#issuecomment-1324003250
and
https://github.com/WebKit/WebKit/pull/6739#issuecomment-1324003775
Similarly on PR
https://github.com/WebKit/WebKit/pull/6705
, there are duplicate comments for same hashes, e.g.:
https://github.com/WebKit/WebKit/pull/6705#issuecomment-1323958169
and
https://github.com/WebKit/WebKit/pull/6705#issuecomment-1323956723
Attachments
Add attachment
proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1
2022-11-22 10:10:53 PST
<
rdar://problem/102609392
>
Aakash Jain
Comment 2
2022-11-22 10:30:39 PST
The extra (duplicate) comments are from uat instance. The links in those comments are to uat instance as well (e.g.:
https://github.com/WebKit/WebKit/pull/6739#issuecomment-1324003250
). This was due to experimentation I was doing on uat instance. I didn't expect it to be able to post to github yet. That was a pleasant surprise. I have turned off the relevant portion now.
Aakash Jain
Comment 3
2023-10-26 06:54:13 PDT
Reopening to land a better solution.
Aakash Jain
Comment 4
2023-10-26 06:56:57 PDT
Pull request:
https://github.com/WebKit/WebKit/pull/19586
EWS
Comment 5
2023-10-26 08:50:49 PDT
Committed
269815@main
(1661161210c4): <
https://commits.webkit.org/269815@main
> Reviewed commits have been landed. Closing PR #19586 and removing active labels.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug