Bug 248205 - APIObject allocated objects leak in ObjC ARC
Summary: APIObject allocated objects leak in ObjC ARC
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Extensions (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Timothy Hatcher
URL:
Keywords: InRadar
Depends on:
Blocks: 248207
  Show dependency tree / graph
 
Reported: 2022-11-21 23:19 PST by Timothy Hatcher
Modified: 2022-11-22 14:31 PST (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Timothy Hatcher 2022-11-21 23:19:31 PST 
Web Extensions is using ARC for the WKWebExtension* classes and it turns out the APIObject wrapper object is causing a strong self reference and it never deallocates the objects.

This was also masking a few other Web Extension leaks and issues.
Comment 1 Timothy Hatcher 2022-11-21 23:33:15 PST 
Pull request: https://github.com/WebKit/WebKit/pull/6724
Comment 2 EWS 2022-11-22 14:30:48 PST 
Committed 256954@main (bbb9a28e9547): <https://commits.webkit.org/256954@main>

Reviewed commits have been landed. Closing PR #6724 and removing active labels.
Comment 3 Radar WebKit Bug Importer 2022-11-22 14:31:16 PST 
<rdar://problem/102612963>