Bug 248199 - Remove Quirk for shouldAutoplayForArbitraryUserGesture on twitter.com and Facebook.com
Summary: Remove Quirk for shouldAutoplayForArbitraryUserGesture on twitter.com and Fac...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: Safari Technology Preview
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Karl Dubost
URL:
Keywords: InRadar
Depends on: 176402 211932 220834
Blocks:
  Show dependency tree / graph
 
Reported: 2022-11-21 18:08 PST by Karl Dubost
Modified: 2022-12-06 17:07 PST (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Karl Dubost 2022-11-21 18:08:30 PST 
See https://github.com/WebKit/WebKit/blob/a0b92719854d2bb1e7cdf41c3d4cedc514ba3a3e/Source/WebCore/page/Quirks.cpp#L152


1. Open Safari with Develop Menu on
2. Deactivate Site Specific Hacks in the Develop Menu
3. Go to https://www.nhl.com/news/toronto-maple-leafs-morgan-rielly-demonstrates-proper-handwashing-technique/c-316213294?tid=281396148
4. Reach the video and do one tap
5. Video starts
6. Go to https://www.universityofgalway.ie/t4training/examples/embedded-videos/
7. Scroll down to reach the embedded Facebook video
8. Tap the video
9. Video Starts

Additional test
10. Go to https://www.facebook.com/stories/
11. ??


// https://bugs.webkit.org/show_bug.cgi?id=176402
// facebook.com https://bugs.webkit.org/show_bug.cgi?id=220834
// twitter.com https://bugs.webkit.org/show_bug.cgi?id=211932
Comment 1 Karl Dubost 2022-11-21 18:18:36 PST 
10. Go to https://www.facebook.com/stories/
11. Working

Confirmed by Tim Nguyen
Comment 2 Karl Dubost 2022-11-21 18:21:07 PST 
Pull request: https://github.com/WebKit/WebKit/pull/6720
Comment 3 Radar WebKit Bug Importer 2022-11-28 18:09:15 PST 
<rdar://problem/102743471>
Comment 4 EWS 2022-12-06 17:07:41 PST 
Committed 257451@main (a1197f89b028): <https://commits.webkit.org/257451@main>

Reviewed commits have been landed. Closing PR #6720 and removing active labels.