Bug 248196 - [LFC][Integration] Cleanup LayoutIntegrationCoverage::canUseForChild
Summary: [LFC][Integration] Cleanup LayoutIntegrationCoverage::canUseForChild
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-11-21 17:17 PST by zalan
Modified: 2022-11-22 09:46 PST (History)
5 users (show)

See Also:

Attachments
Patch (2.96 KB, patch)
2022-11-21 17:43 PST, zalan 		no flags Details | Formatted Diff | Diff
Patch (3.12 KB, patch)
2022-11-21 20:08 PST, zalan 		no flags Details | Formatted Diff | Diff
[fast-cq]Patch (3.25 KB, patch)
2022-11-21 21:31 PST, zalan 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2022-11-21 17:17:57 PST 
ssia
Comment 1 zalan 2022-11-21 17:43:18 PST 
Created attachment 463647 [details]
Patch
Comment 2 Tim Nguyen (:ntim) 2022-11-21 18:07:47 PST 
Comment on attachment 463647 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=463647&action=review

> Source/WebCore/layout/integration/LayoutIntegrationCoverage.cpp:406
>              SET_REASON_AND_RETURN_IF_NEEDED(FlowIsUnsupportedListItem, reasons, includeReasons);

I think you meant ChildBoxIsFloatingOrPositioned ?
Comment 3 zalan 2022-11-21 18:27:28 PST 
(In reply to Tim Nguyen (:ntim) from comment #2)
> Comment on attachment 463647 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=463647&action=review
> 
> > Source/WebCore/layout/integration/LayoutIntegrationCoverage.cpp:406
> >              SET_REASON_AND_RETURN_IF_NEEDED(FlowIsUnsupportedListItem, reasons, includeReasons);
> 
> I think you meant ChildBoxIsFloatingOrPositioned ?
oops. thanks.
Comment 4 zalan 2022-11-21 20:08:13 PST 
Created attachment 463651 [details]
Patch
Comment 5 zalan 2022-11-21 21:31:01 PST 
Created attachment 463658 [details]
[fast-cq]Patch
Comment 6 EWS 2022-11-22 06:22:53 PST 
Committed 256933@main (b10a458bea0e): <https://commits.webkit.org/256933@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 463658 [details].
Comment 7 Radar WebKit Bug Importer 2022-11-22 06:23:16 PST 
<rdar://problem/102605367>