Bug 248191 - Simplify TypingCommand::makeEditableRootEmpty() by removing firstElementChild
Summary: Simplify TypingCommand::makeEditableRootEmpty() by removing firstElementChild
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: HTML Editing (show other bugs)
Version: Safari Technology Preview
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-11-21 13:47 PST by Ahmad Saleem
Modified: 2022-11-22 13:25 PST (History)
3 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ahmad Saleem 2022-11-21 13:47:39 PST 
Hi Team,

While going through Blink commits, I came across another potential simplification:

Blink Commit - https://src.chromium.org/viewvc/blink?view=revision&revision=180673

Webkit GitHub - https://github.com/WebKit/WebKit/blob/68c7e095336e350fb25defd9c5e2cb040a0764e2/Source/WebCore/editing/TypingCommand.cpp#L620

It will simplifies HTML editing code.

Thanks!
Comment 1 EWS 2022-11-22 13:24:53 PST 
Committed 256950@main (b78015aa9a05): <https://commits.webkit.org/256950@main>

Reviewed commits have been landed. Closing PR #6711 and removing active labels.
Comment 2 Radar WebKit Bug Importer 2022-11-22 13:25:17 PST 
<rdar://problem/102612245>