Bug 248118 - Add WebKit::fromAPI(WKEventModifiers) to convert to OptionSet<WebEventModifier>
Summary: Add WebKit::fromAPI(WKEventModifiers) to convert to OptionSet<WebEventModifier>
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: David Kilzer (:ddkilzer)
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-11-18 19:40 PST by David Kilzer (:ddkilzer)
Modified: 2022-11-21 14:33 PST (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description David Kilzer (:ddkilzer) 2022-11-18 19:40:18 PST 
Add WebKit::fromAPI(WKEventModifiers) to convert to OptionSet<WebEventModifier>.

Avoid use of OptionSet<WebEventModifier>::fromRaw() that assumes WKEventModifiers and WebEventModifier have the same enum values.
Comment 1 Radar WebKit Bug Importer 2022-11-18 19:40:35 PST 
<rdar://problem/102539052>
Comment 2 David Kilzer (:ddkilzer) 2022-11-18 19:43:48 PST 
Pull request: https://github.com/WebKit/WebKit/pull/6662
Comment 3 EWS 2022-11-21 14:32:59 PST 
Committed 256917@main (f5fa0df8982c): <https://commits.webkit.org/256917@main>

Reviewed commits have been landed. Closing PR #6662 and removing active labels.